SDLPoP; David's open-source port of PoP

Open-source port of PoP that runs natively on Windows, Linux, etc.
User avatar
Norbert
The Prince of Persia
The Prince of Persia
Posts: 5786
Joined: April 9th, 2009, 10:58 pm

Re: SDLPoP; David's open-source port of PoP

Post by Norbert »

Maybe change this to httpS.
There are 74 other mentions of http (in .c, .h, .txt files) that are httpS nowadays.
Please don't shoot the messenger. ;)
David
The Prince of Persia
The Prince of Persia
Posts: 2877
Joined: December 11th, 2008, 9:48 pm
Location: Hungary

Re: SDLPoP; David's open-source port of PoP

Post by David »

Norbert wrote: October 6th, 2019, 11:33 am Maybe change this to httpS.
There are 74 other mentions of http (in .c, .h, .txt files) that are httpS nowadays.
Please don't shoot the messenger. ;)
It's not that hard to replace them using the "replace in all open documents" feature of NotePad++.
(I used it eariler to update the copyright year.)

The question is, should I replace them in the licence or should licences be kept verbatim?
I have the same question about the GNU URL in the header of every source file.

EDIT: I'm wondering if people typing the URL from the splash screen will even type "https://".
User avatar
Norbert
The Prince of Persia
The Prince of Persia
Posts: 5786
Joined: April 9th, 2009, 10:58 pm

Re: SDLPoP; David's open-source port of PoP

Post by Norbert »

David wrote: October 6th, 2019, 12:09 pmThe question is, should I replace them in the licence or should licences be kept verbatim?
I have the same question about the GNU URL in the header of every source file.
This is a good question. I think you can safely change these to httpS. They changed the license (from, to) and how-to (from, to), but perhaps more relevant, as an example, one of the quintessential GNU packages, coreutils also made this change; see the diff (top section).
David
The Prince of Persia
The Prince of Persia
Posts: 2877
Joined: December 11th, 2008, 9:48 pm
Location: Hungary

Re: SDLPoP; David's open-source port of PoP

Post by David »

Norbert wrote: October 6th, 2019, 12:30 pm This is a good question. I think you can safely change these to httpS.
Done: https://github.com/NagyD/SDLPoP/commit/ ... c543709a58
User avatar
Norbert
The Prince of Persia
The Prince of Persia
Posts: 5786
Joined: April 9th, 2009, 10:58 pm

Re: SDLPoP; David's open-source port of PoP

Post by Norbert »

Nice.
I see you even noticed the "philosophy"->"licenses" URL change. :)
YURA
The Prince of Persia
The Prince of Persia
Posts: 1425
Joined: February 9th, 2017, 11:12 pm

Re: SDLPoP; David's open-source port of PoP

Post by YURA »

Why aren't tile buttons enabled in SDLPoP???
Norbert t David!!! Tell me what you need to include in the program?
viewtopic.php?f=73&t=4361
In DOSBox I work, and in SDLPoP all tiles on/off are not included....
Yes and in other (MOD), too, not included, where there is blue jug with trigger inclusion..
User avatar
Norbert
The Prince of Persia
The Prince of Persia
Posts: 5786
Joined: April 9th, 2009, 10:58 pm

Re: SDLPoP; David's open-source port of PoP

Post by Norbert »

YURA wrote: October 11th, 2019, 4:36 pmWhy aren't tile buttons enabled in SDLPoP???
That is a bug that will be fixed in the next release of SDLPoP (related commit).
So, you'll have to wait for the next release.
YURA
The Prince of Persia
The Prince of Persia
Posts: 1425
Joined: February 9th, 2017, 11:12 pm

Re: SDLPoP; David's open-source port of PoP

Post by YURA »

Norbert wrote: October 11th, 2019, 5:12 pm
YURA wrote: October 11th, 2019, 4:36 pmWhy aren't tile buttons enabled in SDLPoP???
That is a bug that will be fixed in the next release of SDLPoP (related commit).
So, you'll have to wait for the next release.
Thanks for the answer, and when to expect a new version or a fixed file? Roughly on time..
User avatar
Norbert
The Prince of Persia
The Prince of Persia
Posts: 5786
Joined: April 9th, 2009, 10:58 pm

Re: SDLPoP; David's open-source port of PoP

Post by Norbert »

YURA wrote: October 11th, 2019, 5:39 pmThanks for the answer, and when to expect a new version or a fixed file? Roughly on time..
I don't know, David decides.

[Edit: Removed some potentially confusing text from this post.]
David
The Prince of Persia
The Prince of Persia
Posts: 2877
Joined: December 11th, 2008, 9:48 pm
Location: Hungary

Re: SDLPoP; David's open-source port of PoP

Post by David »

Fixed problems with sound priorities, which were reported earlier: https://github.com/NagyD/SDLPoP/commit/ ... 9343f2ba15
Norbert wrote: October 11th, 2019, 6:38 pm
YURA wrote: October 11th, 2019, 5:39 pmThanks for the answer, and when to expect a new version or a fixed file? Roughly on time..
I don't know, David decides.
It could be even this weekend.
Should the new version be 1.19.1 or 1.20?
User avatar
Norbert
The Prince of Persia
The Prince of Persia
Posts: 5786
Joined: April 9th, 2009, 10:58 pm

Re: SDLPoP; David's open-source port of PoP

Post by Norbert »

David wrote: October 12th, 2019, 2:03 pmShould the new version be 1.19.1 or 1.20?
Looking at previous SDLPoP versions, 1.18.1 was an exception that was released 7 days after 1.18 because (emphasis mine):
David wrote: March 24th, 2018, 8:08 pmHere is a new version (v1.18.1) in which I fixed the recently reported bugs of v1.18.
So, I'd use 1.20 for the upcoming regular release.
While it primarily includes fixes, it isn't explicitly(/exclusively) an 'improved iteration' of 1.19.
User avatar
Norbert
The Prince of Persia
The Prince of Persia
Posts: 5786
Joined: April 9th, 2009, 10:58 pm

Re: SDLPoP; David's open-source port of PoP

Post by Norbert »

A SDLPoP-Vita video (how-to, I think).



This might be related:
https://twitter.com/VitaDB1/status/1183411807106600960
User avatar
Norbert
The Prince of Persia
The Prince of Persia
Posts: 5786
Joined: April 9th, 2009, 10:58 pm

Re: SDLPoP; David's open-source port of PoP

Post by Norbert »

Couple dozen visitors to the SDLPoP page at popot.org from a Hungarian post here.
User avatar
Norbert
The Prince of Persia
The Prince of Persia
Posts: 5786
Joined: April 9th, 2009, 10:58 pm

Re: SDLPoP; David's open-source port of PoP

Post by Norbert »

Small bug. In level 7 of Jaffar Strikes Back, this happens in DOS, and this happens in SDLPoP.
David
The Prince of Persia
The Prince of Persia
Posts: 2877
Joined: December 11th, 2008, 9:48 pm
Location: Hungary

Re: SDLPoP; David's open-source port of PoP

Post by David »

Norbert wrote: December 23rd, 2019, 7:47 pm Small bug. In level 7 of Jaffar Strikes Back, this happens in DOS, and this happens in SDLPoP.
The PRINCE.EXE of this mod has this hack, which I didn't yet copy into SDLPoP.

Update:
Fixed it: https://github.com/NagyD/SDLPoP/commit/ ... 5df8d9d274
Post Reply