SDLPoP v1.23 release candidate

Open-source port of PoP that runs natively on Windows, Linux, etc.
Post Reply
David
The Prince of Persia
The Prince of Persia
Posts: 2811
Joined: December 11th, 2008, 9:48 pm
Location: Hungary

SDLPoP v1.23 release candidate

Post by David »

Here is the release candidate of SDLPoP v1.23, attached to the post.
The ZIP contains the Windows binaries and the source as usual.

The list of changes since the last release can be found here: https://github.com/NagyD/SDLPoP/blob/a4 ... #L651-L730

I didn't yet mark this release with a tag in Git. I will do so when the release will be final.
Attachments
SDLPoP_v1.23_RC.zip
(1.81 MiB) Downloaded 42 times
User avatar
Norbert
The Prince of Persia
The Prince of Persia
Posts: 5721
Joined: April 9th, 2009, 10:58 pm

Re: SDLPoP v1.23 release candidate

Post by Norbert »

Nice. And thanks for all the recent Done's. :)
I'll take an extensive look at the RC tomorrow.
Some quickly spotted things that may or may not require action:
- Maybe the splash screen should mention README.md instead of doc/Readme.txt, now that the latter refers to the former. (The same for --help.)
- Maybe remove QUICKSAVE.SAV and screenshots/, that both appear in .gitignore, but somehow got added (maybe you tested functionality?).
- Maybe in SDLPoP.ini both enable_super_high_jump and enable_jump_grab should be on false (I didn't check, maybe they are disabled by default by another variable).
- I see that CMakeLists.txt now has include_directories with "/SDL2", maybe that's deliberate, maybe not.
Again, I'll look through all the files tomorrow.
User avatar
Norbert
The Prince of Persia
The Prince of Persia
Posts: 5721
Joined: April 9th, 2009, 10:58 pm

Re: SDLPoP v1.23 release candidate

Post by Norbert »

Norbert wrote: January 7th, 2023, 10:15 pmAgain, I'll look through all the files tomorrow.
Couple more small things:
- Four more files say "Readme.txt" (SDLPoP.ini, doc/mod.ini, doc/checklist.txt, replays/replays.txt).
- Small typo "trapestry" in seg006.c.
- File doc/mod.ini is outdated at this point, but maybe that's not a problem.
- CMake says seg009.c, line 2138, assignment makes pointer from integer without a cast.
- CMake doesn't know what M_PI is on line 1277 in seg000.c. Possible workaround/fix here: https://stackoverflow.com/a/26065433
- In menu.c, http://www.hackersdelight.org/hdcodetxt/crc.c.txt is a dead link that could be replaced with either https://web.archive.org/web/20190108202 ... /crc.c.txt or https://github.com/hcs0/Hackers-Delight ... /crc.c.txt
- In replay.c, https://wiki.libsdl.org/SDLScancodeLookup no longer exists and has no live replacement (only some things that come close). Maybe convert to an Internet Archive link, or use one of these pages that come close.
That is all from me for this RC.
David
The Prince of Persia
The Prince of Persia
Posts: 2811
Joined: December 11th, 2008, 9:48 pm
Location: Hungary

Re: SDLPoP v1.23 release candidate

Post by David »

Norbert wrote: January 7th, 2023, 10:15 pm - Maybe the splash screen should mention README.md instead of doc/Readme.txt, now that the latter refers to the former. (The same for --help.)
Fixed: https://github.com/NagyD/SDLPoP/commit/ ... 97292e325a
Norbert wrote: January 7th, 2023, 10:15 pm - Maybe remove QUICKSAVE.SAV and screenshots/, that both appear in .gitignore, but somehow got added (maybe you tested functionality?).
The ZIP indeed contains an empty screenshots/ directory, but I don't see QUICKSAVE.SAV.
Norbert wrote: January 7th, 2023, 10:15 pm - Maybe in SDLPoP.ini both enable_super_high_jump and enable_jump_grab should be on false (I didn't check, maybe they are disabled by default by another variable).
They are turned off by use_fixes_and_enhancements = false.
Norbert wrote: January 7th, 2023, 10:15 pm - I see that CMakeLists.txt now has include_directories with "/SDL2", maybe that's deliberate, maybe not.
They were added here: https://github.com/NagyD/SDLPoP/commit/ ... b41f6fffc8
Norbert wrote: January 8th, 2023, 10:57 am - Four more files say "Readme.txt" (SDLPoP.ini, doc/mod.ini, doc/checklist.txt, replays/replays.txt).
Fixed: https://github.com/NagyD/SDLPoP/commit/ ... 97292e325a
Norbert wrote: January 7th, 2023, 10:15 pm - Small typo "trapestry" in seg006.c.
Fixed: https://github.com/NagyD/SDLPoP/commit/ ... 341af9d57b
Norbert wrote: January 7th, 2023, 10:15 pm - File doc/mod.ini is outdated at this point, but maybe that's not a problem.
Fixed: https://github.com/NagyD/SDLPoP/commit/ ... 881149d291
Norbert wrote: January 7th, 2023, 10:15 pm - CMake says seg009.c, line 2138, assignment makes pointer from integer without a cast.
It's this line:

Code: Select all

			sound_names[index] = strdup(name);
Does strdup return an integer in that compiler?
Or, did the compiler just implicitly declare strdup as returning int, because it's not declared in any of the included headers?
(On my system it's in <string.h>, which is included from common.h.)

Related: https://stackoverflow.com/questions/134 ... r-w-o-cast
Norbert wrote: January 7th, 2023, 10:15 pm - CMake doesn't know what M_PI is on line 1277 in seg000.c. Possible workaround/fix here: https://stackoverflow.com/a/26065433
Fixed: https://github.com/NagyD/SDLPoP/commit/ ... 18e9abdb18
Norbert wrote: January 7th, 2023, 10:15 pm - In menu.c, http://www.hackersdelight.org/hdcodetxt/crc.c.txt is a dead link that could be replaced with either https://web.archive.org/web/20190108202 ... /crc.c.txt or https://github.com/hcs0/Hackers-Delight ... /crc.c.txt
- In replay.c, https://wiki.libsdl.org/SDLScancodeLookup no longer exists and has no live replacement (only some things that come close). Maybe convert to an Internet Archive link, or use one of these pages that come close.
Fixed: https://github.com/NagyD/SDLPoP/commit/ ... c37d7cc2b0

Interestingly, the SDL wiki has three pretty much identical tables of scancodes and keycodes, with none telling you the actual numbers behind the names: Their search finds a page called SDLScancodeLookup, but it's a 404 if you open it.
User avatar
Norbert
The Prince of Persia
The Prince of Persia
Posts: 5721
Joined: April 9th, 2009, 10:58 pm

Re: SDLPoP v1.23 release candidate

Post by Norbert »

David wrote: January 14th, 2023, 12:33 pmDoes strdup return an integer in that compiler?
Might be.
Anyway, thanks for making updates.
User avatar
Norbert
The Prince of Persia
The Prince of Persia
Posts: 5721
Joined: April 9th, 2009, 10:58 pm

Re: SDLPoP v1.23 release candidate

Post by Norbert »

Will you release 1.23?
David
The Prince of Persia
The Prince of Persia
Posts: 2811
Joined: December 11th, 2008, 9:48 pm
Location: Hungary

Re: SDLPoP v1.23 release candidate

Post by David »

Here is the v1.23 release.
Attachments
SDLPoP_v1.23_release.zip
(1.82 MiB) Downloaded 34 times
User avatar
Norbert
The Prince of Persia
The Prince of Persia
Posts: 5721
Joined: April 9th, 2009, 10:58 pm

Re: SDLPoP v1.23 release candidate

Post by Norbert »

David wrote: February 11th, 2023, 2:26 pmHere is the v1.23 release.
I've also added it here:
https://www.popot.org/get_the_games.php?game=SDLPoP
And SDLPoP-latest.zip, which is used by (at least) apoplexy, is now also 1.23.

Here's the related video:


And here's the tweet:
Post Reply