SDLPoP; David's open-source port of PoP

[David]

Another minor suggestion. If data/ is not present, for example if a Windows user renamed it to DATA/, then the game still launches and shows the splash screen ("Press any key to continue...") but then displays a black screen that has an invisible prince die when a key is pressed. Some kind of check could be used to determine whether or not the game should display a message about the missing data/ directory on-screen (in-game). Without looking into it thoroughly, maybe if use_custom_levelset is 0 and data/ is not present.

Here is my attempt: https://github.com/NagyD/SDLPoP/commit/ ... ecf0401710

[Norbert]

Here is my attempt: https://github.com/NagyD/SDLPoP/commit/ ... ecf0401710

More user-friendly, yes.

[Norbert]

From the Muting audio thread:

For MININIM use: --sound=false
SDLPoP doesn't have an option for this, but I could add one.

That would be useful.

[David]

From the Muting audio thread:

For MININIM use: --sound=false
SDLPoP doesn't have an option for this, but I could add one.

That would be useful.

Done: https://github.com/NagyD/SDLPoP/commit/ ... c5620591df

[Norbert]

I was browsing a bit and noticed this commit.
It accepts 0-24 as rooms, which totals 25 rooms.
Perhaps that should be 0-23 or 1-24?

[dmitrys]

The room number should not be 0. It is probably just a typo in the "if" statement which only prints out a message.

For me the "used_rooms" value is always 24 even on the pseudo-level 6B in my mod.

[David]

I was browsing a bit and noticed this commit.
It accepts 0-24 as rooms, which totals 25 rooms.
Perhaps that should be 0-23 or 1-24?

The room drawing code repeatedly calls get_room_address() with room = 0, if the current room has no neighbour in at least one of the four directions.

This case is handled by the if (room) condition [if (room != 0)], two lines after the printf().

I don't think I should fill the console with messages about something which is both handled correctly and happens often.

[Coco]

It would be great if David would include some GUI for changing INI file (default mod startup). Though I've never really touched C language, I'm trying to figure out stuff myself. In C#, it wouldn't be a prob, but entire SDLPop takes about 1.5 Mbs, and downloading a whole bunch of .NET stuff for opening a dialog box with a dropdown on linux doesn't quite cut it

[yourantumayel69]

How to edit SDLPoP.ini file? I already put the mods The Shadow and the Flame Remake to SDLPoP/mods/ folder.

[atrueprincefanfrom18]

How to edit SDLPoP.ini file? I already put the mods The Shadow and the Flame Remake to SDLPoP/mods/ folder.

Add levelset = [MOD_FOLDER_NAME]

[atrueprincefanfrom18]

I noticed a weird bug. If you are in front of the mirror (with your reflection shown), if you use cheat (U, G, H, N), after the room is switched to the desired room, the mirror reflection doesn't vanish. It's good if it's fixed.

And also a button to come back to the room where you originally were (before using cheats) would be good. I don't know where that discussion is, but that would be helpful. Backspace button or Home is fine.

[David]

I noticed a weird bug. If you are in front of the mirror (with your reflection shown), if you use cheat (U, G, H, N), after the room is switched to the desired room, the mirror reflection doesn't vanish. It's good if it's fixed.

Fixed: https://github.com/NagyD/SDLPoP/commit/ ... 322707796a

And also a button to come back to the room where you originally were (before using cheats) would be good. I don't know where that discussion is, but that would be helpful. Backspace button or Home is fine.

The discussion is here: viewtopic.php?p=31460#p31460
In SDLPoP, Backspace opens the menu, Home makes the prince jump left.

[atrueprincefanfrom18]

The discussion is here: viewtopic.php?p=31460#p31460

Ah, yes, it's there.

In SDLPoP, Backspace opens the menu, Home makes the prince jump left.

Then maybe a CTRL + B to return where the Kid is?

((SHIFT + B) is taken, that's why CTRL, and B for back to screen?)

[David]

Then maybe a CTRL + B to return where the Kid is?

((SHIFT + B) is taken, that's why CTRL, and B for back to screen?)

Done: https://github.com/NagyD/SDLPoP/commit/ ... c00d70ddbc

[Norbert]

There are inconsistencies in doc/Readme.txt when it comes to how keyboard shortcuts are presented to the reader.

Example:
- - - - -
* Ctrl-S: sound on/off
* mute -- Start the game with sound off. (You can still enable sound with Ctrl+S.)
- - - - -

Another (double) example:
- - - - -
* Shift-F (while viewing a replay): skip forward to the next level
While viewing a replay, you can press F to skip forward to the next room, or Shift+F to skip to the next level.
* shift+left/right: careful step
- - - - -

Yet another example:
- - - - -
* r: resurrect kid
* Ctrl-R: return to intro
- - - - -

Personally, I always do e.g. Ctrl+r (because plus indicates addition, and a capital r (R) would indicate Ctrl+Shift+r).
But I'm not sure whether that is also the best solution in this particular case/context.