princed.org (phpBB forum + webpages)

Prince of Persia related subjects that do not have their own boards.
User avatar
atrueprincefanfrom18
Site Shah
Site Shah
Posts: 1785
Joined: January 21st, 2020, 2:53 pm
Contact:

Re: princed.org (phpBB forum + webpages)

Post by atrueprincefanfrom18 »

David wrote: February 6th, 2021, 1:57 pm
atrueprincefanfrom18 wrote: January 26th, 2021, 12:27 pm The previous design is still available for rollback in case you didn't like this design. You can change it from the UCP.
Sorry, where can I find it within the UCP?
I looked through all tabs and subtabs within the UCP, but I haven't found this option.

I wanted to make a screenshot comparison about what the Manage notifications page looks like with the old and the new theme, as I think the read and the unread items don't look different enough with the new theme.
This is true, it's my fault that I didn't edit the post, even after checking, that you can't rollback. Unfortunately, you can't change the theme from UCP. It used to show an option when I previewed it, but after changing it to the default, the option just somehow disappeared. If you still want to make a comparison, I'll send you a preview link on PM.
Love to create new MODS :)

My complete list of mods until now!

My channel. Do consider subscribing it! :)
Falcury
Calif
Calif
Posts: 565
Joined: June 25th, 2009, 10:01 pm

Re: princed.org (phpBB forum + webpages)

Post by Falcury »

Norbert wrote: February 4th, 2021, 4:03 pm PHP appears to be back at 7.4.x, which means attachments are broken again.
I changed the PHP handler back to 7.3 again.
Hopefully we will be able to fix the underlying issue soon.
User avatar
atrueprincefanfrom18
Site Shah
Site Shah
Posts: 1785
Joined: January 21st, 2020, 2:53 pm
Contact:

Re: princed.org (phpBB forum + webpages)

Post by atrueprincefanfrom18 »

atrueprincefanfrom18 wrote: February 6th, 2021, 2:02 pm
David wrote: February 6th, 2021, 1:57 pm
atrueprincefanfrom18 wrote: January 26th, 2021, 12:27 pm The previous design is still available for rollback in case you didn't like this design. You can change it from the UCP.
Sorry, where can I find it within the UCP?
I looked through all tabs and subtabs within the UCP, but I haven't found this option.

I wanted to make a screenshot comparison about what the Manage notifications page looks like with the old and the new theme, as I think the read and the unread items don't look different enough with the new theme.
This is true, it's my fault that I didn't edit the post, even after checking, that you can't rollback. Unfortunately, you can't change the theme from UCP. It used to show an option when I previewed it, but after changing it to the default, the option just somehow disappeared. If you still want to make a comparison, I'll send you a preview link on PM.
Seems like the default theme should be set to prosilver for normal users to change it via UCP. Anyway, I have set it to prosilver for all of the users. And for my personal settings, I have set to the new theme.
Love to create new MODS :)

My complete list of mods until now!

My channel. Do consider subscribing it! :)
David
The Prince of Persia
The Prince of Persia
Posts: 2848
Joined: December 11th, 2008, 9:48 pm
Location: Hungary

Re: princed.org (phpBB forum + webpages)

Post by David »

David wrote: February 6th, 2021, 1:57 pm I wanted to make a screenshot comparison about what the Manage notifications page looks like with the old and the new theme, as I think the read and the unread items don't look different enough with the new theme.
And here are the screenshots.
In both of them, the first item is unread, the second is read, and the third is hovered by the mouse cursor.

In the old theme, unread items have a darker background.
In the new theme, the only difference between read and unread items is the disabled "Mark read" checkbox.

notifications_old_theme.png
notifications_new_theme.png
David
The Prince of Persia
The Prince of Persia
Posts: 2848
Joined: December 11th, 2008, 9:48 pm
Location: Hungary

Re: princed.org (phpBB forum + webpages)

Post by David »

The search box at the top of every page is unreadable with the new theme.
The placeholder "Search..." text is visible, but once I type in anything, it blends into the background.
User avatar
atrueprincefanfrom18
Site Shah
Site Shah
Posts: 1785
Joined: January 21st, 2020, 2:53 pm
Contact:

Re: princed.org (phpBB forum + webpages)

Post by atrueprincefanfrom18 »

David wrote: February 6th, 2021, 8:56 pm The search box at the top of every page is unreadable with the new theme.
The placeholder "Search..." text is visible, but once I type in anything, it blends into the background.
Yes, you are right. The new theme has some CSS issues. I also fixed the black text on blue background (the theme color) issue, making the text invisible. I'll fix this in some time.
Love to create new MODS :)

My complete list of mods until now!

My channel. Do consider subscribing it! :)
User avatar
Norbert
The Prince of Persia
The Prince of Persia
Posts: 5745
Joined: April 9th, 2009, 10:58 pm

Re: princed.org (phpBB forum + webpages)

Post by Norbert »

I don't want my Norbert account to have moderator privileges.
atrue, I'm guessing you turned this on; can you please turn it off?
Thanks.
David
The Prince of Persia
The Prince of Persia
Posts: 2848
Joined: December 11th, 2008, 9:48 pm
Location: Hungary

Re: princed.org (phpBB forum + webpages)

Post by David »

atrueprincefanfrom18 wrote: February 7th, 2021, 4:08 am Yes, you are right. The new theme has some CSS issues.
I found another colour problem: On the attachments page, most headers blend into the background.
"Mark" is the exception because it's not a link.

As I see it, both this and the search box problem stem from the fact that the same colours are used for elements on both light and dark backgrounds.


The following rules in colours.css need changing:

In this rule, the .forumbg and .forabg selectors are not needed, because the dark background comes from the .header class.
This fixes the header of the attachments page.

Code: Select all

/* Links on gradient backgrounds */
.forumbg .header a, .forabg .header a, th a {
	color: #FFFFFF;
}

.forumbg .header a:hover, .forabg .header a:hover, th a:hover {
	color: #A8D8FF;
}
And in this rule, the ::placeholder should be removed so all text in the search box appears with a contrasting color.

Code: Select all

.search-box .inputbox::placeholder {
  color: #FFFFFF;
}
User avatar
atrueprincefanfrom18
Site Shah
Site Shah
Posts: 1785
Joined: January 21st, 2020, 2:53 pm
Contact:

Re: princed.org (phpBB forum + webpages)

Post by atrueprincefanfrom18 »

Thank you so much. I'll do the needful updates and let know here.

[Edit: Why can I edit your post? --Norbert]
Love to create new MODS :)

My complete list of mods until now!

My channel. Do consider subscribing it! :)
User avatar
Norbert
The Prince of Persia
The Prince of Persia
Posts: 5745
Joined: April 9th, 2009, 10:58 pm

Re: princed.org (phpBB forum + webpages)

Post by Norbert »

atrueprincefanfrom18 wrote: February 8th, 2021, 5:44 am Thank you so much. I'll do the needful updates and let know here.

[Edit: Why can I edit your post? --Norbert]
I (account "Norbert") can edit posts... but why?
I checked the ACP (with "NorbertAdm"), but the only unique group I'm in appears to be "Developers".
And I don't see edit rights for "Developers". The account itself also doesn't seem to have any special privileges.
User avatar
atrueprincefanfrom18
Site Shah
Site Shah
Posts: 1785
Joined: January 21st, 2020, 2:53 pm
Contact:

Re: princed.org (phpBB forum + webpages)

Post by atrueprincefanfrom18 »

Norbert wrote: February 8th, 2021, 4:18 pm
atrueprincefanfrom18 wrote: February 8th, 2021, 5:44 am Thank you so much. I'll do the needful updates and let know here.

[Edit: Why can I edit your post? --Norbert]
I (account "Norbert") can edit posts... but why?
I checked the ACP (with "NorbertAdm"), but the only unique group I'm in appears to be "Developers".
And I don't see edit rights for "Developers". The account itself also doesn't seem to have any special privileges.
We're trying to figure out the issue. Let me get back to other admins as well. Sooner we'll be able to figure out the issue and solve it.
Love to create new MODS :)

My complete list of mods until now!

My channel. Do consider subscribing it! :)
User avatar
atrueprincefanfrom18
Site Shah
Site Shah
Posts: 1785
Joined: January 21st, 2020, 2:53 pm
Contact:

Re: princed.org (phpBB forum + webpages)

Post by atrueprincefanfrom18 »

David wrote: February 7th, 2021, 7:47 pm I found another colour problem: On the attachments page, most headers blend into the background.
"Mark" is the exception because it's not a link.

As I see it, both this and the search box problem stem from the fact that the same colours are used for elements on both light and dark backgrounds.
I couldn't yet change the styles for the attachments page. Looks like if I remove the .forumbg and .forabg classes, the elements using that style on the main page also mess up. I have however fixed the search box by setting text to white always. I think expect for the UCP attachment page, all issues are fixed.
Love to create new MODS :)

My complete list of mods until now!

My channel. Do consider subscribing it! :)
David
The Prince of Persia
The Prince of Persia
Posts: 2848
Joined: December 11th, 2008, 9:48 pm
Location: Hungary

Re: princed.org (phpBB forum + webpages)

Post by David »

atrueprincefanfrom18 wrote: February 8th, 2021, 6:33 pm I couldn't yet change the styles for the attachments page. Looks like if I remove the .forumbg and .forabg classes, the elements using that style on the main page also mess up.
Sorry, I think I wasn't clear enough about what to change.

I meant to change this:

Code: Select all

.forumbg .header a, .forabg .header a, th a {
to this:

Code: Select all

.header a, th a {
And similarly, change this:

Code: Select all

.forumbg .header a:hover, .forabg .header a:hover, th a:hover {
to this:

Code: Select all

.header a:hover, th a:hover {
The main page looks fine to me if I change these using the developer tools.

atrueprincefanfrom18 wrote: February 8th, 2021, 6:33 pm I have however fixed the search box by setting text to white always.
Thank you!
User avatar
atrueprincefanfrom18
Site Shah
Site Shah
Posts: 1785
Joined: January 21st, 2020, 2:53 pm
Contact:

Re: princed.org (phpBB forum + webpages)

Post by atrueprincefanfrom18 »

David wrote: February 13th, 2021, 3:52 pm Sorry, I think I wasn't clear enough about what to change.
Nah, you were, I didn't read it twice before making the changes.
David wrote: February 13th, 2021, 3:52 pm I meant to change this: [...]
Done now, you need to hard refresh to load the changes. And thanks for suggesting the changes!
Love to create new MODS :)

My complete list of mods until now!

My channel. Do consider subscribing it! :)
David
The Prince of Persia
The Prince of Persia
Posts: 2848
Joined: December 11th, 2008, 9:48 pm
Location: Hungary

Re: princed.org (phpBB forum + webpages)

Post by David »

atrueprincefanfrom18 wrote: February 13th, 2021, 4:08 pm Done now, you need to hard refresh to load the changes. And thanks for suggesting the changes!
It works, thank you!
Post Reply