Norbert wrote: ↑May 29th, 2021, 11:15 pm
By the way, maybe you missed
this post?
Although some of that may have been mentioned or discussed in the past.
I can imagine that maybe you don't feel like going into it again.
I have seen it, but I felt that writing one long reply to a long post (about the gcc warnings) would be enough for that day.
Norbert wrote: ↑May 23rd, 2021, 4:22 pm
seg000.c
says
const char quick_version[] = "V1.16b4 ";
I'm not sure if that's still accurate/useful/in use.
This is written into the header of QUICKSAVE.SAV on quicksave.
On quicksave, SDLPoP compares the header of QUICKSAVE.SAV to this string, and fails if they are different.
Norbert wrote: ↑May 23rd, 2021, 4:22 pm
PR has only guards/
SDLPoP/ has GUARD/ GUARD1/ GUARD2/ GUARD.DAT GUARD1.DAT GUARD2.DAT
I'm not sure if all these are necessary.
Originally SDLPoP had only the folders.
I added the DATs because on some systems, loading the paletted images from the GUARD folder results in RGB images.
See here:
viewtopic.php?p=15676#p15676 and
viewtopic.php?p=19603#p19603
SDLPoP needs paletted images, because the palette of the guard images must be changed every time the player meets a guard of a different color.
That can't be done with RGB images.
This problem does not occur with images loaded from DATs, because they are created by SDLPoP explicitly as paletted images.
Norbert wrote: ↑May 23rd, 2021, 4:22 pm
data/levels-original/
data/levels-test/
I'm not sure if that should be in data/ or doc/, and whether it's in use or not.
I used the files in levels-test/ in the past, by copying them over files in data/LEVELS/.
Norbert wrote: ↑May 23rd, 2021, 4:22 pm
doc/mod.ini
I think it's outdated. Maybe remove and modify whatever was pointing to that file to say use SDLPoP.ini as mod.ini and then etc.
mod.ini has all the options commented out, and it also has a different intro text.
Perhaps neither is necessary?
Norbert wrote: ↑May 23rd, 2021, 4:22 pm
Readme.txt
"You need to get the music from here: (38 MB)"
That's actually 42 MB these days, as ogg_MT-32/ was added to the ZIP package.
That part is struck out (<s>...</s>), because SDLPoP can play music from MIDISND*.DAT files and the ZIP is not needed.
However, people might want to download the ZIP to play with MT-32 music, so we could add that.
I was thinking of something like this:
Code: Select all
Where is the music?
----------------------
<s>
Since version 1.13, the game supports loading music from the data/music folder.
Until 1.15, music was not included in releases because it is very big, and it does not change between SDLPoP versions.
Since version 1.15, music is included.
</s>
Since version 1.18, SDLPoP can play music from the MIDISND*.DAT files and OGG files are not included.
You can also play with MT-32 music.
<br>You can get it here: https://www.popot.org/get_the_games.php?game=1
<br>Copy the OGG files from ogg_MT-32 to the data/music folder.
Norbert wrote: ↑May 23rd, 2021, 4:22 pm
When I manually increase the gcc warnings, I get lots of warnings about shadow declarations. That local variables shadow global variables. One reason this is the case is because lots of one-character variables are (re)used, such as i, n, j, m, etc.
Should I just append an "l_" prefix to each such local variable?
About the one-letter variables:
They appear in errors like this:
Code: Select all
stb_vorbis.c [Warning] declaration of 'z' shadows a previous local [-Wshadow]
stb_vorbis.c [Warning] declaration of 'c' shadows a previous local [-Wshadow]
stb_vorbis.c [Warning] declaration of 'n' shadows a parameter [-Wshadow]
Which means:
1. In this case, locals shadow other locals, not globals.
2. These are in stb_vorbis.c, which is not my code, so maybe I shouldn't change it.
Norbert wrote: ↑May 23rd, 2021, 4:22 pm
SDLPoP.ini says
; The base directory where SDLPoP will look for custom levelsets. (default = mods)
mods_folder = mods
And indeed it has: mods/mods.txt
SDLPoP.ini also says
; The folder where replays will be kept.
replays_folder = replays
But it has no: replays/replays.txt (or even replays/)
The above file could be added, so users know where to move downloaded .p1r files.
It could simply point to Readme.txt, sections "Viewing or recording replays" and "REPLAYS".
Done:
https://github.com/NagyD/SDLPoP/commit/ ... 051d49565e
Should I create a screenshots/screenshots.txt as well?
Norbert wrote: ↑May 23rd, 2021, 4:22 pm
Related to the above.
replays-testcases/
should probably be
replays/testcases/
or
doc/replays-testcases/
At least in my opinion.
Of course, if modified, documentation should also be changed to refer to the correct (new) directory.
I don't know.
Norbert wrote: ↑May 23rd, 2021, 4:22 pm
Regardless, it's nice to see that a new SDLPoP release is nearby.
Great project.
Thank you!