SDLPoP v1.18 pre-release

[Falcury]

Falcury, I see you posted some pull requests.
Should I merge all of them (including the MIDI support) before the final v1.18 release?

If you agree with the changes, then sure!
The MIDI support should be good to go as well.

[David]

If you agree with the changes, then sure!
The MIDI support should be good to go as well.

Right then, I merged them. I also updated the project files and the documentation: https://github.com/NagyD/SDLPoP/commits/master

Can I make a final v1.18 release now?
Or maybe fix this before that? https://github.com/NagyD/SDLPoP/issues/157

[Norbert]

Or maybe fix this before that? https://github.com/NagyD/SDLPoP/issues/157

I don't think this is an urgent matter.
To clarify my comment on GitHub, can't the program just check if it's a key down event?
Because if the key down event happened somewhere else and it just gets the key up for Tab, it probably shouldn't react.

[David]

To clarify my comment on GitHub, can't the program just check if it's a key down event?
Because if the key down event happened somewhere else and it just gets the key up for Tab, it probably shouldn't react.

As I replied there, the code is already doing that.

[Falcury]

These things cropped up for me:

• In Ghost of Persia, MIDI parsing fails on the level 2 cutscene song, either causing warning messages about unrecognized event types, or causing a crash.
  The bug is caused by implicit MIDI events. Normally, the event type would be explicitly included in the MIDI stream - however, if the event is of the same type as the previous one, one may omit the event type in order to save a byte. (The last event type is then referred to as the "Running Status".) However, apparently the "Running Status" should remain the same (not be updated) for some MIDI events (namely, 0xF8-0xFF). I did not handle this exception to the rule in the code, so the parsing could go completely wrong in cases where a 0xFF (meta) event was followed by an 'implicit' event.
• Compilation now fails under MSVC because S_ISDIR is not defined.
• I spotted a few errors and typos that I made, mainly with the new CusPop options in SDLPoP.ini.
• In the build instructions in the ReadMe, SDL_mixer would no longer need to be mentioned.
• CMakeLists.txt needed a few updates.

Made a pull request for the above things.
Should this be fixed later, or now?

Sorry for not spotting/fixing this stuff sooner, David. You must be getting quite fed up with me, with all these loose ends

Regardless, yes, of course, release whenever you think the time has come

[Norbert]

To clarify my comment on GitHub, can't the program just check if it's a key down event?
Because if the key down event happened somewhere else and it just gets the key up for Tab, it probably shouldn't react.

As I replied there, the code is already doing that.

[...] but on Linux, there is no such delay.

There is, so SDLPoP has to be checking the state of Tab instead of the event. Or something.
I will add the debug printout you suggested this weekend, although I won't spend a lot of time on it...

[David]

I made a fix that works for me: https://github.com/NagyD/SDLPoP/commit/ ... 96a3e329ce
Please test if it works for you as well.

[Norbert]

Please test if it works for you as well.

The fix works. Thanks.

[Norbert]

So, can I make a final v1.18 release now?

[...] Regardless, yes, of course, release whenever you think the time has come

When the time comes to announce this release on Twitter and Facebook, should I point to the release forum thread, GitHub's releases page, the popot.org page, or perhaps even two of those?

A first draft of the announcement below.
I've tried to include notable improvements this release brings.
Probably still too many chars for Twitter.

SDLPoP 1.18 released, after 13+ months dev! New functionality of this community-driven port of @jmechner's Prince of Persia includes an in-game menu (press ESC), with new settings for lighting, pixel scaling and method, more CusPop-like customization. Support for MIDI music, room and full-level screenshots, etc.

[David]

Here is the (hopefully) final v1.18 release.
It's much smaller than the previous versions, because it does not contain the music in OGG format.

I also marked this version with a tag: https://github.com/NagyD/SDLPoP/releases

GitHub supports attaching binaries to tags. Do you think I should attach this ZIP there as well?

[Norbert]

I've mentioned the release here:
https://twitter.com/PoPModding/status/9 ... 1433538563
https://www.facebook.com/49320251738779 ... 731835426/

[David]

Here is a new version (v1.18.1) in which I fixed the recently reported bugs of v1.18.
viewtopic.php?p=23039#p23039 -- https://twitter.com/blackoilyriver/stat ... 9268865024 (level 7 falling entry)
viewtopic.php?p=23078#p23078 -- https://github.com/NagyD/SDLPoP/pull/168 (level 3 checkpoint)

[Norbert]

Here is a new version (v1.18.1) in which I fixed the recently reported bugs of v1.18.

I've also added it to popot.org.

Should 1.18.1 get an announcement on social media, or do you think it should be fine as-is seeing visitors will now find the most recent version anyway (on GitHub, this forum and PoPOT)?