Page 2 of 2

Re: SDLPoP and SDL 2.0.6

Posted: October 15th, 2017, 11:31 am
by Norbert
David wrote:
October 15th, 2017, 8:26 am
David wrote:
September 24th, 2017, 9:59 pm
Here is the bug report about the popping: https://bugzilla.libsdl.org/show_bug.cgi?id=3846
Further developments:
Ryan marked it as a duplicate, but my bug is still present.
So I attached a recording and some analysis.
Did you also try the patch by Eric (link), as Ryan writes he "went with a different approach" in his revision?
Or perhaps Eric's patch is not applicable to SDLPoP's situation. I'm not familiar enough with the material.

Re: SDLPoP and SDL 2.0.6

Posted: October 21st, 2017, 3:50 pm
by David
It seems that the current version in the SDL repo does not have this bug anymore.
I'm going to find out exactly which commit fixed the bug, and then tell about it in the bug report.

EDIT: Done: https://bugzilla.libsdl.org/show_bug.cgi?id=3846#c5

Re: SDLPoP and SDL 2.0.6

Posted: October 21st, 2017, 6:36 pm
by Norbert
David wrote:
October 21st, 2017, 3:50 pm
EDIT: Done: https://bugzilla.libsdl.org/show_bug.cgi?id=3846#c5
It's good to read that the problem has been solved. I don't think the SDL devs do 2.0.6.x versions, and it may take a while before 2.0.7 arrives, so hopefully the SDL2 package maintainers for Linux distros do some proper patching of 2.0.6 where necessary. For Windows you can simply keep shipping with 2.0.5. In the Linux world programs rely on dynamic libraries, so things might break unless patched properly.

Re: SDLPoP and SDL 2.0.6

Posted: October 29th, 2017, 12:13 am
by Norbert
Norbert wrote:
October 21st, 2017, 6:36 pm
[...], and it may take a while before 2.0.7 arrives, [...]
Version 2.0.7 has already been released:
https://discourse.libsdl.org/t/sdl-2-0-7-released/23279
https://www.libsdl.org/download-2.0.php
So has version 2.0.2 of both SDL_mixer and SDL_image.

Re: SDLPoP and SDL 2.0.6

Posted: October 29th, 2017, 1:54 pm
by David
Norbert wrote:
October 29th, 2017, 12:13 am
Version 2.0.7 has already been released:
https://discourse.libsdl.org/t/sdl-2-0-7-released/23279
https://www.libsdl.org/download-2.0.php
So has version 2.0.2 of both SDL_mixer and SDL_image.
They all work well for me (on Windows XP), I hear no noises in the level door slam or elsewhere.
However, some people are still having problems: https://discourse.libsdl.org/t/sdl-2-0-7-released/23279

Here are the changelogs for the latter projects:
https://libsdl.org/projects/SDL_image/#changes -- They added SVG loading, among other updates...
https://libsdl.org/projects/SDL_mixer/#changes

Re: SDLPoP and SDL 2.0.6

Posted: October 29th, 2017, 11:54 pm
by Falcury
David wrote:
October 29th, 2017, 1:54 pm
However, some people are still having problems: https://discourse.libsdl.org/t/sdl-2-0-7-released/23279
Testing with the 2.0.7 DLL and listening carefully, I am also noticing now that the digital sounds are somehow 'muted' / 'noisy', as if the signal has been lossily compressed. I also have the same problem with the 2.0.6 DLL (as compared to 2.0.5). The music is unaffected.
I wonder if this is the issue that is being reported in the SDL2 2.0.7 release thread.

Re: SDLPoP and SDL 2.0.6

Posted: November 16th, 2017, 4:49 am
by rsn8887
Falcury wrote:
October 29th, 2017, 11:54 pm
David wrote:
October 29th, 2017, 1:54 pm
However, some people are still having problems: https://discourse.libsdl.org/t/sdl-2-0-7-released/23279
Testing with the 2.0.7 DLL and listening carefully, I am also noticing now that the digital sounds are somehow 'muted' / 'noisy', as if the signal has been lossily compressed. I also have the same problem with the 2.0.6 DLL (as compared to 2.0.5). The music is unaffected.
I wonder if this is the issue that is being reported in the SDL2 2.0.7 release thread.
Is there any fix for this?

I have the same problem as @Falcury even with the latest SDL2_mixer 2.0.2 and latest SDL 2.0.8 dev version from GitHub.com/SDL-Mirror.

There is no popping or distortion anymore when the end of level door opens or closes, which is good. But now all digital sounds sound muffled and noisy, like 8 bit quality. It is frustrating to learn that basic sound is still a problem in SDL after all these years.

With the older SDL version 2.0.5, and SDL_mixer 2.0.0, I got terrible sound distortion when the end of level door moved. But at least the digital sound effects such as footsteps, sword noises, platforms falling were crystal clear, similar to CD quality.

Re: SDLPoP and SDL 2.0.6

Posted: November 16th, 2017, 9:58 pm
by Falcury
rsn8887 wrote:
November 16th, 2017, 4:49 am
Is there any fix for this?

I have the same problem as @Falcury even with the latest SDL2_mixer 2.0.2 and latest SDL 2.0.8 dev version from GitHub.com/SDL-Mirror.

There is no popping or distortion anymore when the end of level door opens or closes, which is good. But now all digital sounds sound muffled and noisy, like 8 bit quality. It is frustrating to learn that basic sound is still a problem in SDL after all these years.

With the older SDL version 2.0.5, and SDL_mixer 2.0.0, I got terrible sound distortion when the end of level door moved. But at least the digital sound effects such as footsteps, sword noises, platforms falling were crystal clear, similar to CD quality.
Yeah, I find it annoying as well.
Maybe it would be a good idea to track down the exact revision where the problem first appeared. That could give us some clues.

Re: SDLPoP and SDL 2.0.6

Posted: February 3rd, 2018, 6:08 pm
by David
Falcury wrote:
October 29th, 2017, 11:54 pm
Testing with the 2.0.7 DLL and listening carefully, I am also noticing now that the digital sounds are somehow 'muted' / 'noisy', as if the signal has been lossily compressed.
I tested this with the gate closing sound at the beginning of level 1.
To be honest, I hear the SDL 2.0.7 version as identical to the DOSBox version, and it's the SDL 2.0.5 version that is different.
This was on Windows. I might also test it on Linux.

Re: SDLPoP and SDL 2.0.6

Posted: February 3rd, 2018, 11:46 pm
by Falcury
David wrote:
February 3rd, 2018, 6:08 pm
To be honest, I hear the SDL 2.0.7 version as identical to the DOSBox version, and it's the SDL 2.0.5 version that is different.
Yes, I agree, the SDL 2.0.7 sound is definitely closest to the DOSBox version.
However, there is still a (slight) difference. The DOSBox sound is a bit richer.
Maybe that difference is only easy to hear with a good pair of headphones.