SDLPoP v1.21 release

[Norbert]

` - key which increases the speed of the game has a todo: after drinking a floaty potion the Kid can move very fast however the floaty effect stays longer because music is not at the speed of the game...

Fixed: https://github.com/NagyD/SDLPoP/commit/ ... c9f55b2173
I also added a few related compile-time options.

I'm curious how accurate is this fix. Is it frame-accurate? By that I mean, does the float effect end at the exact same frame as without speed-up? I saw the request/suggestion by atrueprincefanfrom18, and I thought it would be near-impossible to implement - and yet, you apparently pulled it off. My own solution would probably be way more basic, and involve figuring out the number of frames the original sound effect plays. One possible advantage of that route might be that if this total number of frames is then always used, it should work even with custom music.

[atrueprincefanfrom18]

` - key which increases the speed of the game has a todo: after drinking a floaty potion the Kid can move very fast however the floaty effect stays longer because music is not at the speed of the game...

Fixed: https://github.com/NagyD/SDLPoP/commit/ ... c9f55b2173
I also added a few related compile-time options.

I'm curious how accurate is this fix. Is it frame-accurate? By that I mean, does the float effect end at the exact same frame as without speed-up? I saw the request/suggestion by atrueprincefanfrom18, and I thought it would be near-impossible to implement - and yet, you apparently pulled it off.

Even I thought it would be a difficult to do this. If it could have been easy, David would have done it initially itself when the feature was developed.

[David]

I'm curious how accurate is this fix. Is it frame-accurate? By that I mean, does the float effect end at the exact same frame as without speed-up?

Unfortunately it isn't.
I added some debug printouts where is_feather_fall is set to 1 or 0, and these were the results:

Without fast forward:
slow fall started at: rem_min = 60, rem_tick = 589
slow fall ended at: rem_min = 60, rem_tick = 414
Length of the slow fall: 589-414 = 175 ticks (frames)

With fast forward:
slow fall started at: rem_min = 59, rem_tick = 706
slow fall ended at: rem_min = 59, rem_tick = 464
Length of the slow fall: 706-464 = 242 ticks (frames)

[Norbert]

Unless I'm misunderstanding you, that is way off then... right?
(242-175)/12=about 6 seconds difference.
Probably better to at least also end slow fall at 175 ticks in fast-forward mode...

[David]

Unless I'm misunderstanding you, that is way off then... right?
(242-175)/12=about 6 seconds difference.
Probably better to at least also end slow fall at 175 ticks in fast-forward mode...

I tested this again, and it turned out that part of this big difference is an artifact of how I tested.
Namely, in the 175 ticks case, the slow fall music was interrupted be the exit door opening.
(There is a fix for this bug, called FIX_FEATHER_INTERRUPTED_BY_LEVELDOOR.)

When I wrote my previous post, I tested it on the original level 7 in the following way:
For the non-fast-forward case, I grabbed the ledge, pressed Shift+W, released the ledge, fell down, then I opened the gate and ran right, opening the exit door.
For the fast-forward, I just let the prince fall down.


So now I tested it again, this time with the prince standing still.
(The lengths are off by one tick because of the way I made SDLPoP calculate them. See here: https://github.com/NagyD/SDLPoP/commit/ ... 8cfc03e0ce )

normally (without fast-forward):

Code: Select all

slow fall started at: rem_min = 60, rem_tick = 655
slow fall ended at: rem_min = 60, rem_tick = 430
length = 226 ticks

slow fall started at: rem_min = 60, rem_tick = 337
slow fall ended at: rem_min = 60, rem_tick = 113
length = 225 ticks

slow fall started at: rem_min = 53, rem_tick = 579
slow fall ended at: rem_min = 53, rem_tick = 355
length = 225 ticks

slow fall started at: rem_min = 53, rem_tick = 235
slow fall ended at: rem_min = 53, rem_tick = 10
length = 226 ticks

with fast-forward:

Code: Select all

slow fall started at: rem_min = 58, rem_tick = 509
slow fall ended at: rem_min = 58, rem_tick = 267
length = 243 ticks

slow fall started at: rem_min = 58, rem_tick = 66
slow fall ended at: rem_min = 57, rem_tick = 547
length = 239 ticks

slow fall started at: rem_min = 57, rem_tick = 342
slow fall ended at: rem_min = 57, rem_tick = 105
length = 238 ticks

slow fall started at: rem_min = 56, rem_tick = 603
slow fall ended at: rem_min = 56, rem_tick = 337
length = 267 ticks

Now the numbers are much less off, but they are still different.
Note how the length of the feather fall in fast-forward mode is quite variable, much more than in normal mode.


I have added a condition to stop the feather fall if it has been going on for more than 225 ticks: https://github.com/NagyD/SDLPoP/commit/ ... 6079deb39b


I remember there are some mods which make the feather fall longer, probably by replacing its music with something longer.
This change might break this feature of those mods.

However, I can't find any such mod.
I looked at Flying Prince, whose description says "Has special levels with a longer flying time, which is required to finish the levels.".
But the feather fall music doesn't seem longer, in fact all the sound files are the same as in the original v1.0 game!

[Norbert]

I have added a condition to stop the feather fall if it has been going on for more than 225 ticks: [...]

Nice.

But the feather fall music doesn't seem longer, in fact all the sound files are the same as in the original v1.0 game!

By the looks of it, its ZIP file contains files auto-added by Total Pack.
Probably I took the files from a Total Pack that for this 2007 mod didn't contain all the original files.

[atrueprincefanfrom18]

I remember there are some mods which make the feather fall longer, probably by replacing its music with something longer.
This change might break this feature of those mods.

However, I can't find any such mod.
I looked at Flying Prince, whose description says "Has special levels with a longer flying time, which is required to finish the levels.".
But the feather fall music doesn't seem longer, in fact all the sound files are the same as in the original v1.0 game!

There's this Hurry Up Prince mod. Does the changed code work as expected? Try Level 6 where you have to float from Room 6 to Room 16, I guess (check the comments).

P.S: Maybe if the loaded DAT files are not the original (are from mods folder), you could store the tick count (at which the feather fall should end) and then compare with the tick count instead of 225 as you did here? Don't really know if it's possible for SDLPoP to find out the tick count and how much time it might take or anything like that, but I think you could give it a try.

[David]

But the feather fall music doesn't seem longer, in fact all the sound files are the same as in the original v1.0 game!

By the looks of it, its ZIP file contains files auto-added by Total Pack.
Probably I took the files from a Total Pack that for this 2007 mod didn't contain all the original files.

Here is the original archive of Flying Prince from 2007.
All DAT files are equal to those in the PoPOT version of this mod.

[Norbert]

Here is the original archive of Flying Prince from 2007.
All DAT files are equal to those in the PoPOT version of this mod.

Then maybe he simply meant that the prince flies longer (distance/time) than in the original game.
I'll point him to this thread via email, maybe he can chime in.

[mmitch5]

Hi,

This was 13 years ago from now but I can tell you that in one of my levelset called " flying prince " there is a long flight required to finish the level 7 or 8 from left up to down right and If you touch the duration of the prince being able to fly after drinking the flying potion you will not be able to finish the level .. I did not touch modify the time duration of the jump flight after drinking the potion as this was not really an option a that time.
I do not think this is very good idea as this will affect other levelset as well I guess

[yourantumayel69]

Hi,

This was 13 years ago from now but I can tell you that in one of my levelset called " flying prince " there is a long flight required to finish the level 7 or 8 from left up to down right and If you touch the duration of the prince being able to fly after drinking the flying potion you will not be able to finish the level .. I did not touch modify the time duration of the jump flight after drinking the potion as this was not really an option a that time.
I do not think this is very good idea as this will affect other levelset as well I guess

Hey, you're comeback😂🤣

[atrueprincefanfrom18]

Hey, you're comeback😂🤣

Many people might, if someone shoots them an email.

[David]

There's this Hurry Up Prince mod. Does the changed code work as expected? Try Level 6 where you have to float from Room 6 to Room 16, I guess (check the comments).

In SDLPoP the slow fall ends too soon.

In this mod the slow fall music is unchanged, instead the game itself has been made slightly faster.
SDLPoP cannot detect this change, which means that this mod (probably) didn't work properly in SDLPoP even before I added the 225 ticks limit.

[atrueprincefanfrom18]

There's this Hurry Up Prince mod. Does the changed code work as expected? Try Level 6 where you have to float from Room 6 to Room 16, I guess (check the comments).

In SDLPoP the slow fall ends too soon.

In this mod the slow fall music is unchanged, instead the game itself has been made slightly faster.
SDLPoP cannot detect this change, which means that this mod (probably) didn't work properly in SDLPoP even before I added the 225 ticks limit.

Oh, does SDLPoP also speed up the game as the numbers suggests in Apoplexy (F2 screen)?

[David]

Oh, does SDLPoP also speed up the game as the numbers suggests in Apoplexy (F2 screen)?

No it doesn't (yet).